Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js-sys: add Object.fromEntries #1456

Merged
merged 2 commits into from
Apr 26, 2019

Conversation

bakkot
Copy link
Contributor

@bakkot bakkot commented Apr 14, 2019

Fixes #1453.

I couldn't actually get tests to pass, possibly because Node does not yet support this function.

@bakkot
Copy link
Contributor Author

bakkot commented Apr 14, 2019

Yeah, looks like CI has the same problem as I did locally. I'd appreciate input from a maintainer here - to my (uneducated) eye, it looks like tests in CI are being run in Firefox, but Firefox has had support for Object.fromEntries since version 63 (released in October 2018) and Azure's Ubuntu agent claims claims to be running Firefox 66.

@alexcrichton
Copy link
Contributor

Oh so crates/js-sys/tests/wasm/* is actually all executed in Node.js which may explain the discrepancy here, but can you try adding the tests to crates/js-sys/tests/headless.rs as those should be run in Firefox on Azure?

@bakkot
Copy link
Contributor Author

bakkot commented Apr 15, 2019

Hm. I believe Node 12 will include v8 7.4, which includes Object.fromEntries. It's due to be cut on April 23. So maybe it'd be simpler to just wait for that?

@alexcrichton
Copy link
Contributor

Seems reasonable to me!

@alexcrichton
Copy link
Contributor

I just updated to node 12 in #1484, want to rebase this and see if it works?

@bakkot bakkot force-pushed the object-from-entries branch from 2bc948f to a32d255 Compare April 26, 2019 03:52
@bakkot bakkot force-pushed the object-from-entries branch from be390a6 to 70480ad Compare April 26, 2019 04:21
@bakkot
Copy link
Contributor Author

bakkot commented Apr 26, 2019

@alexcrichton looks like it worked! (Once I fixed the silly bug in the test, anyway.)

@alexcrichton alexcrichton merged commit 38fcfc3 into rustwasm:master Apr 26, 2019
@bakkot bakkot deleted the object-from-entries branch May 18, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stage 4 JS proposal: Object.fromEntries
3 participants