Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix direct imports in --target web #1503

Merged
merged 1 commit into from
May 1, 2019

Conversation

alexcrichton
Copy link
Contributor

Currently the import object constructed for the --target web output
only ever includes the current module as an one of the modules included.
With wasm-bindgen's optimization to import directly from modules,
however, it's possible to have more modules imported from in the
generated wasm file. This commit ensures that the imports are hooked up
in the --target web es6 emulation mode, ensuring there aren't
extraneous errors about import objects.

@alexcrichton alexcrichton requested a review from fitzgen May 1, 2019 18:58
Currently the import object constructed for the `--target web` output
only ever includes the current module as an one of the modules included.
With `wasm-bindgen`'s optimization to import directly from modules,
however, it's possible to have more modules imported from in the
generated wasm file. This commit ensures that the imports are hooked up
in the `--target web` es6 emulation mode, ensuring there aren't
extraneous errors about import objects.
@alexcrichton alexcrichton merged commit a13eb10 into rustwasm:master May 1, 2019
@alexcrichton alexcrichton deleted the fix-web-imports branch May 1, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants