Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues around web-sys dictionaries #1572

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Fix small issues around web-sys dictionaries #1572

merged 2 commits into from
Jun 3, 2019

Conversation

alexcrichton
Copy link
Contributor

  • Generate dictionary types even if some of their required fields are filtered out. They're not too useful, but they'll at least exist, get things compiling, and make the existing docs accurate.
  • Generate documentation for dictionaries and dictionary fields, ensuring they're listed with what features are necessary to activate the API

Closes #1569

@alexcrichton
web-sys: Don't remove dictionaries if required fields are removed
877c31c 
This commit updates the conditional binding generation for dictionaries
to ensure that a dictionary is not entirely removed if any of its
required fields are removed. If a required field is removed, however, it
cannot be constructed, so the constructor is removed.
@alexcrichton
Add doc comments to web-sys dictionaries/fields
117928f 
This commit ensures that web-sys generated dictionaries and fields all
have comments like interfaces do, indicating a bare minimum of what's
happening as well as the required features to enable the API.
@alexcrichton alexcrichton requested a review from fitzgen June 3, 2019 20:20
fitzgen
fitzgen approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

@fitzgen fitzgen merged commit 6ac61b5 into rustwasm:master Jun 3, 2019
@alexcrichton alexcrichton deleted the dictionary-fields branch June 3, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RtcPeerConnection::set_local_description generated documentation for required features is wrong
2 participants
@alexcrichton @fitzgen