Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Element::get_elements_by_class_name #1665

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

ia0
Copy link
Contributor

@ia0 ia0 commented Jul 13, 2019

No description provided.

@alexcrichton
Copy link
Contributor

Thanks for this! While you're at it, mind removing the comment markers entirely from this block with this method? The comments AFAIK were added quite some time ago when web-sys was first being developed, but they shouldn't be necessary any more and we should implement all the methods!

@ia0 ia0 force-pushed the getElementsByClassName branch from c1d15d1 to 170ce68 Compare July 15, 2019 17:47
@ia0
Copy link
Contributor Author

ia0 commented Jul 15, 2019

Sure, no problem!

@alexcrichton alexcrichton merged commit 1807de7 into rustwasm:master Jul 15, 2019
@alexcrichton
Copy link
Contributor

👍

@ia0 ia0 deleted the getElementsByClassName branch July 15, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants