Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't log routine errors as out-of-the-ordinary #1788

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Don't log routine errors as out-of-the-ordinary #1788

merged 1 commit into from
Sep 25, 2019

Commits on Sep 24, 2019

  1. Don't log routine errors as out-of-the-ordinary 

    To benefit users in debug mode we log any unexpected exceptions to help
diagnose any issues that might arise. It turns out, though, we log this
for *every* exception happening for *every* import, including imports
like `__wbindgen_throw` which are explicitly intended to throw an
exception. This can cause distracting debug logs to get emitted to the
console, so let's squelch the debug logging for known imports that we
shouldn't log for, such as intrinsics.

Closes rustwasm#1785
    @alexcrichton
    alexcrichton committed Sep 24, 2019
    Configuration menu
    Copy the full SHA
    9c576b1 View commit details
    Browse the repository at this point in the history