Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more webkit-specific whitelist in web-sys #1865

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

alexcrichton
Copy link
Contributor

Adds OfflineAudioContext to the list of types that may have the webkit prefix, as mentioned here

@alexcrichton
Copy link
Contributor Author

I'm gonna hold off on merging this until @tat-m3dicine confirms this works

@tat-m3dicine
Copy link

Beautiful work! I can instantiate webkitAudioOfflineContext on Safari without any problem!
Just making sure that I followed the step on contributing.md correctly, I've done following steps:

  1. cd crates/web-sys && cargo build
  2. import and use web_sys::OfflineAudioContext in examples/webaudio/lib.rs

Screen Shot 2019-11-21 at 9 15 30 am

@alexcrichton alexcrichton merged commit aa461c3 into rustwasm:master Nov 21, 2019
@alexcrichton alexcrichton deleted the more-webkit-polyfills branch November 21, 2019 15:30
@alexcrichton
Copy link
Contributor Author

Nice, thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants