Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the loading logic for the
web
andno-modules
targets in the following ways:It's now possible to pass a
Promise<WebAssembly.Module>
,Promise<ArrayBuffer>
, orPromise<Response>
to thewasm_bindgen
function.That also means that it's now possible to do
wasm_bindgen(fetch("foo"))
which previously wasn't possible.This makes it easier to use wasm-bindgen when serving the
.wasm
from cache (e.g. in service workers).Some code duplication has been removed.
The logic is now much clearer and easier to understand.
The old logic
The new logic