Fix name collisions with test functions and intrinsics #2123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an unfortunate collision with how test symbols were named and the various bindings functions exported by wasm-bindgen. This commit fixes these issues by using a separate prefix for `#[wasm_bindgen_test]` than other `#[wasm_bindgen]` functions which should avoid the name clash. Closes rustwasm#2121
quodlibetor
added a commit
to schrieveslaach/chrono
that referenced
this pull request
Jul 5, 2020
wasm-bindgen-test and wasm-bindgen need to be different versions (0.3 and 0.2, respectively), otherwise no tests are found([1], [2]); This also fixes the test to and ci runner to just test in the current env/tz, thereby requiring that js_sys returns the same timezone as the host system thinks it is, but not otherwise trying to set the TZ. [1]: https://users.rust-lang.org/t/wasm-bindgen-test-and-no-tests-to-run/43444 [2]: rustwasm/wasm-bindgen#2123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an unfortunate collision with how test symbols were named and
the various bindings functions exported by wasm-bindgen. This commit
fixes these issues by using a separate prefix for
#[wasm_bindgen_test]than other
#[wasm_bindgen]functions which should avoid the nameclash.
Closes #2121