-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement OptionIntoWasmAbi
for `Option<&Closure>.
#2191
base: main
Are you sure you want to change the base?
Implement OptionIntoWasmAbi
for `Option<&Closure>.
#2191
Conversation
IntoWasmAbi
for `Option<&Closure>.OptionIntoWasmAbi
for `Option<&Closure>.
Thanks! Can you be sure to add some tests for this as well? |
Sure! Could you suggest what I should test for? |
In general I'd just exercise this feature. Make sure |
Cool! (thanks) |
@teymour-aldridge thanks for starting this! Any luck adding tests? |
Hi, I've been a bit busy recently so haven't had time to work on this much. If you'd like to add some tests, please feel free. |
I added a test to tests/wasm/closures.rs, but I'm not sure how to run the tests. When I run |
I see. I was missing |
I added a basic test that you can see in #2211. Unfortunately, this does not fix it yet and I am not sure how to. |
I think this is the correct way to do it. I'm not sure about that though (my knowledge about WebAssembly is very limited).
This should resolve #2173.