Pass actual stack pointers around instead of address 8 #2249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the implementation of passing return pointers from JS to wasm to actually modify the wasm's shadow stack pointer instead of manufacturing the arbitrary address of 8. The purpose of this is to correctly handle threaded scenarios where each thread will write to its own area instead of everyone trying to compete at address 8. The implementation here will lazily, if necessary, export the stack pointer we find the module and modify it as necessary. Closes rustwasm#2218
fitzgen
approved these changes
Jul 23, 2020
alexcrichton
force-pushed
the
fix-threaded-sp
branch
3 times, most recently
from
0157bf6 to
e8a2af2
Compare
alexcrichton
force-pushed
the
fix-threaded-sp
branch
from
e8a2af2 to
5a10654
Compare
|
Ah, this is awesome! Thanks @alexcrichton for implementing this. I totally did not get around it and had too much on my plate. Sorry I couldn't get involved earlier and work on a PR. When do you cut the next version of wasm-bindgen that includes this fix? |
|
No worries! I basically do releases when requested, no schedule currently. Would you like a release to be made? |
|
Yep, that would be amazing, so I could bumped the version in my project and make sure the js binding is thread safe. |
|
Ok, I'm doing the bump at #2256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the implementation of passing return pointers from
JS to wasm to actually modify the wasm's shadow stack pointer instead of
manufacturing the arbitrary address of 8. The purpose of this is to
correctly handle threaded scenarios where each thread will write to its
own area instead of everyone trying to compete at address 8.
The implementation here will lazily, if necessary, export the stack
pointer we find the module and modify it as necessary.
Closes #2218