Refactor: normalized encoding of ImportModule #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaslihotzki
force-pushed
the
normalized-importmodule
branch
from
bb1361e
to
405dce1
Compare
|
This change helps with correctly supporting all kinds of paths in #3034. |
Liamolucko
reviewed
Sep 7, 2022
lukaslihotzki
force-pushed
the
normalized-importmodule
branch
from
2e6ccc1
to
f0b166e
Compare
Liamolucko
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With uninterpreted paths (not starting with
./,../, or/),ImportModule::NamedandImportModule::RawNamedare equivalent (because the attributes are too). However, while the attributes should be designed for user convenience, the binary encoding should be optimized for simple processing. Attribute handling should be done purely in themacro-supportcrate. Therefore, it makes sense to normalize uninterpreted paths toImportModule::RawNamedin the binary encoding.