-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebIDLs for experimental AudioContext sinkId, setSinkId #3433
Conversation
Okay what I can gather from the failing CI is there's an issue because I mistakenly hard-coded the experimental feature decorators in I can see now they need to be included in the |
Yes, you should be able to use Let me know if you encounter any problems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should implement the rest of the interface too:
AudioSinkInfo
AudioSinkOptions
AudioSinkType
BaseAudioContext.onsinkchange
AudioContextOptions.sinkId
To generate the WebIDL correctly you have to run the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Missing an entry in the changelog.
* added unstable AudioContext partial with audio sink types * unrelated to sink, but I also added latencyHint to AudioContextOptions as it's stable
Thanks @tylerbarker! I just rebased and fixed the changelog. |
Hey, I'm working on some audio stuff and found these features I need were missing - thought it might be useful to contribute? Let me know if I'm missing something or have done this incorrectly. Cheers ✌️