-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Notification APIs #3667
Conversation
I don't exactly understand why this on check didn't go through. I followed the contribution guidelines. What can I do to fix this? |
This is just missing the --- a/crates/web-sys/Cargo.toml
+++ b/crates/web-sys/Cargo.toml
@@ -880,6 +880,7 @@ NodeFilter = []
NodeIterator = []
NodeList = []
Notification = ["EventTarget"]
+NotificationAction = []
NotificationBehavior = []
NotificationDirection = []
NotificationEvent = ["Event", "ExtendableEvent"]
You probably forgot to point the tool towards the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the corresponding fields to Notification
?
See https://notifications.spec.whatwg.org/#api.
I replaced the whole idl file now with the latest spec from that link. I hope that's ok? It makes some breaking changes but the previous version of the notification API seems to have been very old. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately we can't just correct the API like this because that would require a breaking change.
I think removing GetNotificationOptions
, NotificationBehavior
and Notification.get()
is fine though because they don't actually exist anymore. @Liamolucko and @hamza1311 would you be fine with that as well?
Could you also add a note in the changelog? Especially mention the removal of these APIs separately.
Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: daxpedda <daxpedda@gmail.com>
Co-authored-by: daxpedda <daxpedda@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is LGTM.
Just gonna wait for another maintainer to confirm the API removals.
Yeah, I'm fine with this. |
I'm fine with it. If it "breaks" any code, that code is already broken and now there is an error message for it at compile time. |
No description provided.