Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing typeof operator in __wbg_init() template in no-modules #3748

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

bbradshaw
Copy link
Contributor

I noticed a TypeError originating in the generated javascript wrapper when using the --no-modules flag (I was messing around with web workers which can result in script_src actually being undefined).

It appears the check is for undefined is against the value of string_src, rather than the type.

Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have messed this up before, not sure what happened here.
Thank you!

Could you add a note in the changelog?

@bbradshaw bbradshaw requested a review from daxpedda December 20, 2023 15:51
CHANGELOG.md Outdated Show resolved Hide resolved
@daxpedda daxpedda merged commit cc9a219 into rustwasm:main Dec 20, 2023
23 checks passed
@bbradshaw
Copy link
Contributor Author

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants