Shrink JS-allocated strings down to the correct size before passing them to Rust #3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khoover
reviewed
Jan 23, 2024
| @@ -1314,6 +1309,7 @@ impl<'a> Context<'a> { | |||
| const ret = encodeString(arg, view); | |||
| {debug_end} | |||
| offset += ret.written; | |||
| ptr = realloc(ptr, len, offset, 1) >>> 0; | |||
There was a problem hiding this comment.
Could add a check for whether len != offset before reallocing again, to avoid spurious allocs.
There was a problem hiding this comment.
I considered that, but I didn't think it'd be worth it since in the vast majority of cases the string won't take up the maximum amount of space anyway.
I'd be fine to add it if you want but I don't think the difference would be significant either way.
daxpedda
reviewed
Jan 23, 2024
…hem to Rust Fixes rustwasm#3801. I opted to solve it this way rather than just pass the capacity to Rust as well because it means the allocation isn't up to 3x bigger than it needs to be anymore. I also removed a TODO about fixing that.
Liamolucko
force-pushed
the
shrink-string-buf
branch
from
f483e15
to
170aba2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3801.
I opted to solve it this way rather than just pass the capacity to Rust as well because it means the allocation isn't up to 3x bigger than it needs to be anymore. I also removed a TODO about fixing that.