-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support expr when use typescript_custom_section
attribute
#3901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't mean to rush you , but any progress about this pr @daxpedda |
Unfortunately I'm not really qualified to review any TS related stuff, so I leave it to other maintainers. |
Liamolucko
reviewed
Apr 9, 2024
include fix typo and adding whitespace to ensure consistent code style. Co-authored-by: Liam Murphy <liampm32@gmail.com>
…n order to avoid unsafe code
…lain why there are different types of LitOrExpr when encoding and decoding
Liamolucko
reviewed
Apr 9, 2024
Liamolucko
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you add a changelog entry?
Support Expressions when using the `typescript_custom_section` attribute[rustwasm#3901]
Thanks for your patience, I've updated the changelog |
Liamolucko
reviewed
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for example
this pr is inspired by #3308 , and will fix [#2828]
this pr is compatible with current encode logic, so
wasm-bindgen cli
can decode normally without updating