Register target features in custom section when using xforms #3967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liamolucko
reviewed
May 23, 2024
Liamolucko
reviewed
May 26, 2024
Liamolucko
reviewed
May 26, 2024
|
|
||
| // The first byte contains an integer describing the target feature count, which we increase by one. | ||
| let mut data = Cursor::new(§ion.data); | ||
| let count = leb128::read::unsigned(&mut data).unwrap(); |
There was a problem hiding this comment.
This shouldn't use unwrap, since it can fail if data ends while it's still reading or the integer doesn't fit in a u64.
There was a problem hiding this comment.
This can't fail because we already read it successfully beforehand (or return an error on failure) or inserted it correctly ourselves if no section was found.
Let me know if I missed something!
There was a problem hiding this comment.
Ah, good point, I didn't think about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that tools like
wasm-optdon't like it when we use reference types but don't actually register them in the appropriate custom section as specified in the tooling convention(which is out of date).