Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add deviceMemory to Navigator IDL #4011

Merged
merged 4 commits into from
Jul 28, 2024
Merged

feat: add deviceMemory to Navigator IDL #4011

merged 4 commits into from
Jul 28, 2024

Conversation

tltsutltsu
Copy link
Contributor

No description provided.

@tltsutltsu
Copy link
Contributor Author

The only failed CI check is Test TypeScript output of wasm-bindgen, which is failing on other branches also, so I am opening this PR for review.

@tltsutltsu tltsutltsu marked this pull request as ready for review July 12, 2024 16:31
daxpedda
daxpedda requested changes Jul 28, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay!

This API should be contained in its own WebIDL file and marked as unstable.

@daxpedda daxpedda merged commit f423bd9 into rustwasm:main Jul 28, 2024
25 checks passed
@tltsutltsu
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tltsutltsu @daxpedda