Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce MSRV policy #4038

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Introduce MSRV policy #4038

merged 1 commit into from
Aug 2, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Aug 2, 2024

This PR introduces a MSRV policy.

Library crates have an MSRV of v1.57 and changes to the MSRV are accompanied by a minor version bump.
The following crates are included in this policy:

  • wasm-bindgen
  • js-sys
  • web-sys
  • wasm-bindgen-futures
  • wasm-bindgen-test
  • wasm-bindgen-macro
  • wasm-bindgen-test-macro
  • wasm-bindgen-macro-support
  • wasm-bindgen-backend
  • wasm-bindgen-shared

CLI crates and their support libraries have an MSRV of v1.76, due to being dependent on the wasm-tools ecosystem. The MSRV is only guaranteed for a specific version, so it is only accompanied by a patch version bump.
The following crates are included in this policy:

  • wasm-bindgen-cli
  • wasm-bindgen-cli-support
  • wasm-bindgen-wasm-interpreter
  • wasm-bindgen-threads-xform
  • wasm-bindgen-multi-value-xform
  • wasm-bindgen-externref-xform
  • wasm-bindgen-wasm-conventions

Fixes #3114.
Fixes #3918.

@daxpedda daxpedda merged commit e58ff18 into rustwasm:main Aug 2, 2024
27 checks passed
@Liamolucko
Copy link
Collaborator

Library crates have an MSRV of v1.57 and changes to the MSRV are accompanied by a minor version bump.

That's a lot stronger of a policy than I would have expected: since all of those crates are at 0.x.y, a minor version bump is effectively a major version bump, and so we'll be stuck at an MSRV of 1.57 until we make a breaking release.

@daxpedda
Copy link
Collaborator Author

daxpedda commented Aug 3, 2024

Library crates have an MSRV of v1.57 and changes to the MSRV are accompanied by a minor version bump.

That's a lot stronger of a policy than I would have expected: since all of those crates are at 0.x.y, a minor version bump is effectively a major version bump, and so we'll be stuck at an MSRV of 1.57 until we make a breaking release.

Yep.
I don't see us really raising the MSRV considering we don't really have any dependencies.

Do you disagree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm-bindgen is broken and untested at MSRV (1.57) Document MSRV
2 participants