Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

derive(Debug) for JsError #4136

Merged
merged 2 commits into from
Oct 7, 2024
Merged

derive(Debug) for JsError #4136

merged 2 commits into from
Oct 7, 2024

Conversation

rcrisanti
Copy link
Contributor

This should allow using .unwrap() & .expect() on it, in unit tests for example.

Resolves #4099.

@rcrisanti rcrisanti mentioned this pull request Oct 2, 2024
Closed
@rcrisanti @daxpedda
derive(Debug) for JsError
bc670c8 
This should allow using `.unwrap()` & `.expect()`
on it, in unit tests for example.

Resolves rustwasm#4099.
daxpedda
daxpedda approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit c1acd31 into rustwasm:main Oct 7, 2024
37 of 38 checks passed
@rcrisanti rcrisanti deleted the jserror-debug branch October 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wasm_bindgen::JsError doesn't implement Debug
2 participants
@rcrisanti @daxpedda