Use the global allocator, not the system allocator #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
approved these changes
Oct 10, 2018
This was previously causing us to accidentally always pull in the system allocator, even if users were trying to just use a custom global allocator.
|
In case of using different global allocator (for example wee_alloc), without this patch the functions __wbindgen_malloc etc. would still link against dlmalloc, increasing wasm-binary-footprint by around 20KB, and causing issues using two different dynamic memory allocators, internally wee_alloc and another one (dlmalloc) being used by exported functions __wbindgen_malloc, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously causing us to accidentally always pull in the system allocator, even if users were trying to just use a custom global allocator.