Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example commands in docs broken by PR #851 #1035

Merged
merged 1 commit into from
Aug 7, 2021

Conversation

fkettelhoit
Copy link
Contributor

@fkettelhoit fkettelhoit commented Jul 20, 2021

Since #851 was merged, both wasm-pack build and wasm-pack test directly pass extra arguments to cargo build and cargo test without the need for an additional --. This PR updates the docs to reflect this change.

EDIT: I just noticed that wasm-pack build did not yet use the same syntax as wasm-pack test, which would be fixed by #1037 and should be merged first for the doc changes of this PR to make sense.


Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Copy link
Member

@drager drager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@drager drager merged commit 67a543f into rustwasm:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants