-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a --debug option to suppress cargo build --release. #127
Conversation
I don't know much about rustfmt but I assume the cargo fmt error is related to this recent work: |
Yeah I think this is why. I've opened up an issue and will get a fix in for it. |
If you can rebase this that would be great. We fixed the CI issue. I do think this needs to be discussed in #126 before we consider merging this though. |
βοΈ
Yep. I'm aware I kindof dropped this on you. |
@clanehin hey! i'd love to merge this- it's gonna need a rebase and some documentation- are you up for it? let me know! (and if you need any help/guidance, please ask away!) |
This should be rebased and doc'ed. I haven't done a lot of collaborative github in a while so if I've missed anything at this point then I'm oblivious to it. |
As regards #153, I'll have to follow up maybe next week. Maybe sensible to let the upstream discussion solidify anyway? |
thanks so much, checking this out locally and then i'll merge! πΎ π¬ β¨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π π
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as well :) Great job!
Yay, thank you! |
First pass at #126 .
Make sure these boxes are checked! π¦β
rustfmt
installed and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightly
rustfmt
on the code base before submittingβ¨β¨ π Thanks so much for contributing to wasm-pack! π β¨β¨