Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX for pack and publish path expectations #198

Merged
merged 12 commits into from
Jul 19, 2018
Merged

Improve UX for pack and publish path expectations #198

merged 12 commits into from
Jul 19, 2018

Commits on Jul 4, 2018

  1. Return custom error if pkg directory is not found

    @Mackiovello
    Mackiovello committed Jul 4, 2018
    Configuration menu
    Copy the full SHA
    840c7bd View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2018

  1. Simplify match expression

    @Mackiovello
    Mackiovello committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    035bcbe View commit details
    Browse the repository at this point in the history

  2. Use custom error message for publish

    @Mackiovello
    Mackiovello committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    ec17b8a View commit details
    Browse the repository at this point in the history

  3. Make error more specific

    @Mackiovello
    Mackiovello committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    8efabfa View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2018

  1. Search for path in entered directory and the parent of entered 

    This lets us have backwards compatibility while improving the user experience.
    @Mackiovello
    Mackiovello committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    b57d68f View commit details
    Browse the repository at this point in the history

  2. Use 'find_pkg_directory' for pack

    @Mackiovello
    Mackiovello committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    a67762a View commit details
    Browse the repository at this point in the history

  3. Check child directories instead of parent directory

    @Mackiovello
    Mackiovello committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    63c91ca View commit details
    Browse the repository at this point in the history

  4. Write as more ideomatic rust

    @Mackiovello
    Mackiovello committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    ac34e7b View commit details
    Browse the repository at this point in the history

  5. Simplify iteration even more

    @Mackiovello
    Mackiovello committed Jul 7, 2018
    Configuration menu
    Copy the full SHA
    e6cd7bb View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2018

  1. Fix npm-pack command to use correct path

    @Mackiovello
    Mackiovello committed Jul 10, 2018
    Configuration menu
    Copy the full SHA
    ce77e5c View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2018

  1. Merge branch 'master' of https://github.com/rustwasm/wasm-pack into i… 

    …ssue/189
    @Mackiovello
    Mackiovello committed Jul 14, 2018
    Configuration menu
    Copy the full SHA
    28d5bb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. Add documentation for pack and publish

    @Mackiovello
    Mackiovello committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    88fdbc5 View commit details
    Browse the repository at this point in the history