Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): udpate fixtures for new rust feature flags #222

Merged
merged 2 commits into from
Jul 24, 2018
Merged

fix(tests): udpate fixtures for new rust feature flags #222

merged 2 commits into from
Jul 24, 2018

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jul 24, 2018 •
edited
Loading

fixes #219

@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jul 24, 2018
@ashleygwilliams ashleygwilliams added this to the 0.4.2 milestone Jul 24, 2018
@ashleygwilliams ashleygwilliams changed the title fix(tests): udpate fixtures for new rust feature flags [WIP] fix(tests): udpate fixtures for new rust feature flags Jul 24, 2018
@ashleygwilliams ashleygwilliams added needs review and removed work in progress do not merge! labels Jul 24, 2018
@ashleygwilliams ashleygwilliams changed the title [WIP] fix(tests): udpate fixtures for new rust feature flags fix(tests): udpate fixtures for new rust feature flags Jul 24, 2018
mgattozzi
mgattozzi approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@mgattozzi mgattozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's just wait for CI to pass before merging

@ashleygwilliams ashleygwilliams merged commit dd30b88 into master Jul 24, 2018
@ashleygwilliams ashleygwilliams deleted the bingen-breakage-fix branch July 24, 2018 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgattozzi mgattozzi mgattozzi approved these changes

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

Unable to init project because of compiler errors with proc-macro2
2 participants
@ashleygwilliams @mgattozzi