Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(depcheck): don't fail on dep map #224

Merged
merged 2 commits into from
Jul 25, 2018
Merged

fix(depcheck): don't fail on dep map #224

merged 2 commits into from
Jul 25, 2018

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jul 24, 2018 •
edited
Loading

fixes #221

@ashleygwilliams ashleygwilliams changed the title fix(depcheck): add failing test to repro bug [WIP] fix(depcheck): add failing test to repro bug Jul 24, 2018
@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jul 24, 2018
@ashleygwilliams ashleygwilliams added this to the 0.4.2 milestone Jul 24, 2018
@ashleygwilliams ashleygwilliams changed the title [WIP] fix(depcheck): add failing test to repro bug [WIP] fix(depcheck): don't fail on dep map Jul 24, 2018
@turboladen
Copy link

🥇

@ashleygwilliams ashleygwilliams force-pushed the fix-depcheck branch 3 times, most recently from bdd9d28 to 80244e3 Compare July 25, 2018 00:17
@ashleygwilliams ashleygwilliams changed the title [WIP] fix(depcheck): don't fail on dep map fix(depcheck): don't fail on dep map Jul 25, 2018
@ashleygwilliams ashleygwilliams added needs review and removed work in progress do not merge! labels Jul 25, 2018
@ashleygwilliams ashleygwilliams force-pushed the fix-depcheck branch 2 times, most recently from e67b9f3 to a06ce53 Compare July 25, 2018 00:26
fitzgen
fitzgen approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

@ashleygwilliams ashleygwilliams merged commit 05e4743 into master Jul 25, 2018
@ashleygwilliams ashleygwilliams deleted the fix-depcheck branch July 25, 2018 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@mgattozzi mgattozzi Awaiting requested review from mgattozzi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.2
Development

Successfully merging this pull request may close these issues.

wasm-bindgen dep check should not fail on dep map
3 participants
@ashleygwilliams @turboladen @fitzgen