modules modules modules #312
Conversation
ashleygwilliams
force-pushed
the
mod-mod-mod
branch
from
d08522f
to
33eccd3
Compare
ashleygwilliams
force-pushed
the
mod-mod-mod
branch
from
eea0c02
to
f06f3cc
Compare
src/manifest/mod.rs
Outdated
| None => {} | ||
| } | ||
|
|
||
| NpmPackage::ES6Package(ES6Package { |
There was a problem hiding this comment.
nitpick: I'd probably name this EsModulePackage since I think modules didn't come until after es6 and es6 is also actually es2015 or some such... or something like that, right?
There was a problem hiding this comment.
yeah that actually makes a bunch of sense, good catch
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
mod-mod-mod
branch
from
7f52a38
to
7f38eb9
Compare
ashleygwilliams
force-pushed
the
mod-mod-mod
branch
from
442ee7f
to
195c4e1
Compare
ashleygwilliams
changed the title
src/manifest/mod.rs
Outdated
| if let Some(s) = scope { | ||
| self.package.name = format!("@{}/{}", s, self.package.name); | ||
| } | ||
| let mut files = vec![wasm_file, js_file.clone()]; |
There was a problem hiding this comment.
this clone. i hate it but i also love not having a ton of lifetime parameters everywhere. i think it's fine but if we hate it let's talk about ways to make it as clean as possible.
There was a problem hiding this comment.
I don't think this single allocation that isn't in a loop (or even within any code that we know to be hot) is a problem. 👍
src/manifest/mod.rs
Outdated
| if let Some(s) = scope { | ||
| self.package.name = format!("@{}/{}", s, self.package.name); | ||
| } | ||
| let mut files = vec![wasm_file, js_file.clone()]; |
There was a problem hiding this comment.
I don't think this single allocation that isn't in a loop (or even within any code that we know to be hot) is a problem. 👍
src/manifest/mod.rs
Outdated
| } | ||
|
|
||
| /// Check the data for missing fields and warn | ||
| pub fn check_optional_fields( |
There was a problem hiding this comment.
Would it be possible to have this be a function in the impl of the package type so that you can just call:
self.check_optional_fields();
rather than feeding it from three separate variables and avoiding possibly calling the function incorrectly?
There was a problem hiding this comment.
oh! that's a great idea. can do :)
src/manifest/mod.rs
Outdated
| Some(format!("{}.d.ts", filename)) | ||
| }; | ||
|
|
||
| if let Some(s) = scope { |
There was a problem hiding this comment.
This scope handling logic looks duplicated between this and the above?
There was a problem hiding this comment.
this is all from master but yeah you are right i think, file an issue?
src/manifest/mod.rs
Outdated
| let dts_file = if disable_dts == true { | ||
| None | ||
| } else { | ||
| Some(format!("{}.d.ts", filename)) |
There was a problem hiding this comment.
This dts logic looks duplicated with the above?
There was a problem hiding this comment.
this is all from master but yeah you are right i think, file an issue?
There was a problem hiding this comment.
i guess i can try to fix it in this PR, might as well
|
@alexcrichton correct, this is just to lay the groundwork for #313 |
|
Great job @ashleygwilliams! |
fixes #309 plus rather large refactor which is in the first few commits
strategy here is to define several struct for types of packages folks will want to make (common js only, es6 only, es6 + commonjs to start), we'll serialize the Cargo.toml into the format based on what the target specified is