Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop reading cargo toml many times #431

Merged
merged 6 commits into from
Nov 5, 2018
Merged

Stop reading cargo toml many times #431

merged 6 commits into from
Nov 5, 2018

Commits on Nov 5, 2018

  1. Only read the Cargo.toml manifest once 

    And then keep reusing what we read, instead of re-reading it again.

Fixes rustwasm#25
    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    4e6abcf View commit details
    Browse the repository at this point in the history

  2. Refactor: replace manifest::read_cargo_toml with a constructor

    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    511e6c2 View commit details
    Browse the repository at this point in the history

  3. Refactor: make write_package_json a method on CargoManifest

    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    0e09b3f View commit details
    Browse the repository at this point in the history

  4. Refactor: make get_crate_name a method of CargoManifest

    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2549030 View commit details
    Browse the repository at this point in the history

  5. Refactor: make check_crate_config a method of CargoManifest

    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    6d3e9df View commit details
    Browse the repository at this point in the history

  6. Run cargo fmt

    @fitzgen
    fitzgen committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    098eb33 View commit details
    Browse the repository at this point in the history