Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor license copy to remove unwrap() #476

Merged
merged 2 commits into from
Jan 2, 2019

Conversation

mstallmo
Copy link
Member

Closes #475

I've changed the code that utilized unwrap()and handled the None case of the option explicitly returning an Error if we get a None.

Side note: I also refactored a couple of places in the file based on some clippy linting warnings.


Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a great improvement! thanks so much :)

@ashleygwilliams ashleygwilliams merged commit 8af4002 into rustwasm:master Jan 2, 2019
@mstallmo mstallmo deleted the refactor-license-copy branch January 2, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor use of unwrap when copying license files
2 participants