Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bindgen version & fix some cache issue #526

Closed
wants to merge 22 commits into from

Conversation

huangjj27
Copy link
Member

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

closes #519 and fixes #447

danwilhelm and others added 12 commits January 12, 2019 01:12
`child::run` overrides the stdout config, so is misleading to to set it
differently beforehand. `child::run` uses `spawn()`, which inherits
stdin by default. So, no need to set stdin to default beforehand,
particularly when the spawned program is non-interactive.
Issue rustwasm#277 - Affects running login, pack, and publish on Windows.

`Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a
run-time error on Windows. Now, `Command::new` is wrapped by
`child::new_command(program: &str)`. This prepends `cmd /c` to the
program name if `cfg!(windows)`.

See rustc: #42436, #42791, #44542
This commit replaces the `slog` family of crates used by `wasm-pack`
with the `log` crate plus `env_logger`. This also means that by default
`wasm-pack` also won't create a `wasm-pack.log` file in the current
directory. Enabling logging will now be done through
`RUST_LOG=wasm_pack` instead of `-v` flags.

Closes rustwasm#425
@huangjj27
Copy link
Member Author

the failling test printed test output at both stdout and stderr. where the stdout is not expected.

CHANGELOG.md Outdated Show resolved Hide resolved
@ashleygwilliams
Copy link
Member

@huangjj27 is this still a work in progress? we should figure out that failing test- lemme know if you want help! i'll make as a WIP until i hear back from you

@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jan 28, 2019
@ashleygwilliams ashleygwilliams changed the title Update bindgen version & fix some cache issue [WIP] Update bindgen version & fix some cache issue Jan 28, 2019
@huangjj27
Copy link
Member Author

huangjj27 commented Jan 29, 2019

I don’t think the failing test caused by, my PR, as I only change the wasm-bindgen version. In other word, the code is finished and can be merged, with the failing test to be solved in an independent PR.

@huangjj27 huangjj27 changed the title [WIP] Update bindgen version & fix some cache issue Update bindgen version & fix some cache issue Feb 11, 2019
@ashleygwilliams ashleygwilliams added this to the 0.7.0 milestone Feb 22, 2019
I believe the older code has something wrong so it install wasm-bindgen
from cargo, but now it can download
the prebuilt version.

fixes rustwasm#447
because the assert commaned seems to capture stdout in err string,
work around the test faing by double the log counts
@huangjj27
Copy link
Member Author

@ashleygwilliams I think the PR is ready,and @csmoe has reviewed my code,please check and merge

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for your efforts and patience!

@ashleygwilliams
Copy link
Member

closing in favor of #554

alexcrichton added a commit to alexcrichton/wasm-pack that referenced this pull request Mar 7, 2019
This fixes an accidental regression from rustwasm#554 which was in turn an
accidental regression from rustwasm#526
alexcrichton added a commit to alexcrichton/wasm-pack that referenced this pull request Mar 7, 2019
This fixes an accidental regression from rustwasm#554 which was in turn an
accidental regression from rustwasm#526
@alexcrichton alexcrichton mentioned this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump up the wasm-bindgen version in test? Not reusing cache in test
5 participants