Update bindgen version & fix some cache issue #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`child::run` overrides the stdout config, so is misleading to to set it differently beforehand. `child::run` uses `spawn()`, which inherits stdin by default. So, no need to set stdin to default beforehand, particularly when the spawned program is non-interactive.
Issue rustwasm#277 - Affects running login, pack, and publish on Windows. `Command::new("npm")` launched `npm` with quotes, `"npm"`, causing a run-time error on Windows. Now, `Command::new` is wrapped by `child::new_command(program: &str)`. This prepends `cmd /c` to the program name if `cfg!(windows)`. See rustc: #42436, #42791, #44542
Windows fixes
This commit replaces the `slog` family of crates used by `wasm-pack` with the `log` crate plus `env_logger`. This also means that by default `wasm-pack` also won't create a `wasm-pack.log` file in the current directory. Enabling logging will now be done through `RUST_LOG=wasm_pack` instead of `-v` flags. Closes rustwasm#425
Alexcrichton log
csmoe
reviewed
Jan 28, 2019
|
@huangjj27 is this still a work in progress? we should figure out that failing test- lemme know if you want help! i'll make as a WIP until i hear back from you |
ashleygwilliams
changed the title
|
I don’t think the failing test caused by, my PR, as I only change the wasm-bindgen version. In other word, the code is finished and can be merged, with the failing test to be solved in an independent PR. |
huangjj27
changed the title
ashleygwilliams
added
merge conflict
needs review
and removed
work in progress
I believe the older code has something wrong so it install wasm-bindgen from cargo, but now it can download the prebuilt version. fixes rustwasm#447
huangjj27
force-pushed
the
update-bindgen-version
branch
from
8432eda
to
d56a944
Compare
because the assert commaned seems to capture stdout in err string, work around the test faing by double the log counts
|
@ashleygwilliams I think the PR is ready，and @csmoe has reviewed my code，please check and merge |
ashleygwilliams
approved these changes
Feb 26, 2019
|
closing in favor of #554 |
alexcrichton
added a commit
to alexcrichton/wasm-pack
that referenced
this pull request
Mar 7, 2019
This fixes an accidental regression from rustwasm#554 which was in turn an accidental regression from rustwasm#526
alexcrichton
added a commit
to alexcrichton/wasm-pack
that referenced
this pull request
Mar 7, 2019
This fixes an accidental regression from rustwasm#554 which was in turn an accidental regression from rustwasm#526
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submittingcloses #519 and fixes #447