Support license-file field in Cargo.toml #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nse field in Cargo.toml
In 'license' field of package.json, it's ok to say 'license is written in
some file' as follows:
```
{ "license" : "SEE LICENSE IN <filename>" }
```
This notation is useful when 'license' field is missing in `Cargo.toml`
but `license-file` field is provided.
Ref:
https://docs.npmjs.com/files/package.json#license
'license-file' field is provided in Cargo.toml for providing path of license file. https://doc.rust-lang.org/cargo/reference/manifest.html
ashleygwilliams
approved these changes
Jan 28, 2019
|
actually- this can go into 0.6.1, merging now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submittingIn my package, no
licensefield is provided inCargo.toml, butlicense-fileis provided. I noticedwasm-packdoes not copy license file specified inlicense-filefield.https://doc.rust-lang.org/cargo/reference/manifest.html
This patch supports
license-filefield by following two additions:wasm-packcopies file specified inlicense-fileinCargo.tomlintopkgdirectory"SEE LICENSE IN <filename>"tolicensefield ofpackage.json. This is standard way documented in official npm document: https://docs.npmjs.com/files/package.json#licenseI added one new test case to check my implementation works fine.
👍