Support license-file field in Cargo.toml #527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! π¦β
rustfmt
installedcargo fmt
on the code base before submittingIn my package, no
license
field is provided inCargo.toml
, butlicense-file
is provided. I noticedwasm-pack
does not copy license file specified inlicense-file
field.https://doc.rust-lang.org/cargo/reference/manifest.html
This patch supports
license-file
field by following two additions:wasm-pack
copies file specified inlicense-file
inCargo.toml
intopkg
directory"SEE LICENSE IN <filename>"
tolicense
field ofpackage.json
. This is standard way documented in official npm document: https://docs.npmjs.com/files/package.json#licenseI added one new test case to check my implementation works fine.
π