Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 'homepage' field of Cargo.toml and package.json #531

Merged
merged 2 commits into from
Jan 28, 2019

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jan 27, 2019

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt-preview --toolchain nightly
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text
    • I searched 'homepage' word but no open issue was found

Both Cargo.toml and package.json have homepage field. They are meaning the same so I thought homepage field should be copied from Cargo.toml into package.json. This patch implements the feature.

Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much!

@ashleygwilliams ashleygwilliams added this to the 0.6.1 milestone Jan 28, 2019
@ashleygwilliams ashleygwilliams merged commit 37606c2 into rustwasm:master Jan 28, 2019
@fitzgen fitzgen added the TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly label Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - feature TWiRaWA Nominate this PR for inclusion in the next issue of This Week in Rust and WebAssembly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants