-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust webpack template tutorial #536
Conversation
Co-authored-by: Patrick McCarver <patrick@merklebros.com>
If you'd like to save some time writing the deep dives, the |
Hey @xtuc this PR is ready for review. I'm happy to make changes based on any feedback. Thanks for offering to look this over. |
}); | ||
``` | ||
|
||
## Run The Project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't needed, Webpack's wasm-pack-plugin will spawn wasm-pack. Only npm start
or npm run build
in the root directory is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining that! I pushed up a change that I think reflects that a little better in the docs now.
@DebugSteven is this ready for review? Let me know! And thanks for all the effort! I'm excited for this to land :) |
@ashleygwilliams It's ready for review! Thanks for your patience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll probably try to consolidate some of the duplication before the next release but this is really great!! thank you so much for all your efforts here!! <3
This is a work in progress PR for the rust webpack template tutorial.
At the moment, I believe the workflow to use the template is filled in pretty well. There are empty WIP files to talk more about the generated
src/lib.rs
file & theweb-sys
dependency in theCargo.toml
, in addition to the other dependencies & crate type that are discussed in the npm-browser-packages template tutorial.I'd appreciate feedback on content so far & possibly what to do about duplication across tutorials, if that's a priority.