generate #623

ashleygwilliams · 2019-04-11T15:02:00Z

fixes #373

todo: respect noinstall
todo: lookup version of latest
docs
tests

ashleygwilliams · 2019-04-12T19:42:19Z

this is still a WIP since i need to sort the testing but i'd love some feedback on the approach. additionally @alexcrichton if you rebase your #625 i think you can take advantage of some of the refactoring i've done here

alexcrichton

All's looking good to me!

README.md

alexcrichton · 2019-04-12T20:01:25Z

docs/src/commands/generate.md

+The `wasm-pack generate` command can be given and optional name argument, e.g.:
+
+```
+wasm-pack generate --name myproject


I wonder if it might be better to wasm-pack generate myproject? That jives with cargo new and I think commands like git init as well.

so the reason i did a flag was that you can also pass --template.. we could have name be positional tho and still have the other flags. i think conforming to similar tools makes more sense.

Ah yeah I meant just having --name be a positional argument instead (but keeping --template). We could perhaps take a leaf out of git clone's book though and do something like:

# generates a new project named "foo" $ wasm-pack generate https://github.com/alexcrichton/foo # generates a new project named "bar" $ wasm-pack generate https://github.com/alexcrichton/foo bar

I don't really feel too strongly any direction, but I do think that having the name be a positional argument rather than a flag might be nice.

i really like this.

i think this would be a neat feature but let's put it off til another PR as i'm worried this one is getting a lil big

src/generate.rs

alexcrichton · 2019-04-12T20:06:52Z

src/install/krate.rs

+use serde::Deserialize;
+
+#[derive(Debug, Deserialize)]
+pub struct Krate {


FWIW I typically only use "krate" for the literal name "crate", but other variations like "Crate" I tend to use instead of "Krate" b/c it's valid Rust both ways (only crate is invalid)

src/install/mod.rs

alexcrichton · 2019-04-12T20:08:56Z

Cargo.toml

@@ -23,6 +23,7 @@ glob = "0.2"
 log = "0.4.6"
 openssl = { version = '0.10.11', optional = true }
 parking_lot = "0.6"
+reqwest = "0.9.14"


Could this perhaps use curl to use the same downloading backend as binary-install?

would you mind if we did this in another PR- it's... a little tricky with the interface and i'm worried this PR is getting pretty big cc @drager

Personally I think that would be fine, as long as we have a tracking issue for it and planning to do it in the near future.

Ok, deferring it to an issue seems fine

docs/src/commands/generate.md

alexcrichton · 2019-04-12T20:18:28Z

To bikeshed a little bit, if we ignore backwards compatibility and that wasm-pack init was historically a subcommand, would be perhaps best named as wasm-pack init or wasm-pack new? This seems akin to cargo new and cargo init to me (which arguably both should take template parameters)

ashleygwilliams · 2019-04-12T20:37:58Z

@alexcrichton i honestly had the same feeling when i was making this PR, new and init seem better and are a lot easier to type.

i think init has been deprecated for a lot of cycles at this point. i'd be open to replacing it, or we can go with new.

alexcrichton · 2019-04-12T21:20:53Z

I think I'd vote for new over init since it's creating directories rather than initializing pre-existing ones (sorta like cargo new/init), but I'm not sure how much precedent there is for that distinction honestly

src/command/mod.rs

src/generate.rs

alexcrichton · 2019-04-19T15:41:13Z

One recommendation I might have for testing comes from Cargo's test suite which is to use local file paths to git repositories. The general idea would be to make a builder-style API which creates a bunch of files in a directory, and then has a build() method which writes it all out and then turns it into a git repository with one commit as well. The result of build() could then be a Url which is actually just a file path, and then wasm-pack generate is invoked with that URL to ensure that it basically calls cargo generate and the right results show up (pass in a few different names, etc)

The various git helpers for Cargo are located in https://github.com/rust-lang/cargo/blob/master/tests/testsuite/support/git.rs and largely rely on git2, but using the CLI here would probably also be fine.

drager · 2019-05-16T18:23:16Z

docs/src/commands/index.md

@@ -3,9 +3,14 @@
 `wasm-pack` has several commands to help you during the process of building
 a Rust-generated WebAssembly project.

- `init`: This command has been deprecated in favor of `build`.
+- `new`: This command generates a new project for you using a template. [Learn more][generate]


Broken link here? Shouldn't it be [Learn more][new]?

drager · 2019-05-16T18:26:19Z

docs/src/commands/new.md

+```
+
+The mode pass can be either "normal", "noinstall", or "force". "normal is passed by
+degault.


Suggested change

degault.

default.

drager · 2019-05-16T18:27:53Z

.travis.yml

@@ -52,8 +52,8 @@ matrix:
    - cargo fmt --version
    - cargo fmt --all -- --check
    - rustup component add clippy-preview
-    - cargo clippy --version
-    - cargo clippy
+#    - cargo clippy --version


Shouldn't these be brought back?

drager · 2019-05-16T18:28:47Z

docs/src/quickstart.md

+1. `cd hello-wasm`
+1. Run `wasm-pack build`.
+1. This tool generates files in a `pkg` dir
+1. To publish to npm, run `wasm-pack publish`. You may need to login to the


Should we consider mention that publishing to npm is optional?

drager · 2019-05-16T19:18:23Z

@ashleygwilliams About the tests I agree with you that some more test would be nice to have. However, I think we can add those afterwards. Let's get this PR merged first.

ashleygwilliams added work in progress do not merge! changelog - feature labels Apr 11, 2019

ashleygwilliams added this to the 0.9.0 milestone Apr 11, 2019

ashleygwilliams added needs docs please add docs to this PR needs tests please add tests to this PR labels Apr 11, 2019

ashleygwilliams force-pushed the generate branch 5 times, most recently from 38fc3e1 to a6bbcfd Compare April 11, 2019 20:37

ashleygwilliams requested review from alexcrichton and drager April 12, 2019 19:41

alexcrichton reviewed Apr 12, 2019

View reviewed changes

ashleygwilliams removed the needs docs please add docs to this PR label Apr 12, 2019

ashleygwilliams commented Apr 12, 2019

View reviewed changes

docs/src/commands/generate.md Outdated Show resolved Hide resolved

ashleygwilliams removed the needs tests please add tests to this PR label Apr 12, 2019

ashleygwilliams mentioned this pull request Apr 12, 2019

Add support for automatically executing wasm-opt #625

Merged

drager reviewed Apr 13, 2019

View reviewed changes

src/command/mod.rs Outdated Show resolved Hide resolved

src/generate.rs Outdated Show resolved Hide resolved

ashleygwilliams removed the work in progress do not merge! label Apr 15, 2019

ashleygwilliams changed the title ~~[WIP] generate~~ generate Apr 15, 2019

ashleygwilliams force-pushed the generate branch 2 times, most recently from 88ce9b5 to fb9a671 Compare April 15, 2019 16:15

ashleygwilliams force-pushed the generate branch from ee2be85 to 290a0e4 Compare May 16, 2019 14:24

feat(command): add generate command

d6baf43

ashleygwilliams force-pushed the generate branch from 290a0e4 to d6baf43 Compare May 16, 2019 15:03

ashleygwilliams requested review from alexcrichton and drager May 16, 2019 15:03

ashleygwilliams added 2 commits May 16, 2019 10:25

fix(lint): re-enable clippy, fix lints

b96538e

fix(lint): ignore redundant closures

8407a1d

drager reviewed May 16, 2019

View reviewed changes

alexcrichton approved these changes May 16, 2019

View reviewed changes

ashleygwilliams merged commit a267075 into master Jun 11, 2019

ashleygwilliams deleted the generate branch June 11, 2019 09:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

generate #623

generate #623

ashleygwilliams commented Apr 11, 2019 •

edited

Loading

ashleygwilliams commented Apr 12, 2019

alexcrichton left a comment

alexcrichton Apr 12, 2019

ashleygwilliams Apr 12, 2019

alexcrichton Apr 12, 2019

ashleygwilliams Apr 12, 2019

ashleygwilliams Apr 15, 2019

alexcrichton Apr 12, 2019

alexcrichton Apr 12, 2019

ashleygwilliams Apr 15, 2019

drager Apr 16, 2019

alexcrichton Apr 16, 2019

alexcrichton commented Apr 12, 2019

ashleygwilliams commented Apr 12, 2019

alexcrichton commented Apr 12, 2019

alexcrichton commented Apr 19, 2019

drager May 16, 2019

drager May 16, 2019

drager May 16, 2019

drager May 16, 2019

drager commented May 16, 2019

generate #623

generate #623

Conversation

ashleygwilliams commented Apr 11, 2019 • edited Loading

ashleygwilliams commented Apr 12, 2019

alexcrichton left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexcrichton commented Apr 12, 2019

ashleygwilliams commented Apr 12, 2019

alexcrichton commented Apr 12, 2019

alexcrichton commented Apr 19, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drager commented May 16, 2019

ashleygwilliams commented Apr 11, 2019 •

edited

Loading