Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add user agent for wasm-pack version check #658

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

drager
Copy link
Member

@drager drager commented May 25, 2019

This PR adds a user agent header for the wasm-pack version check. It will look like this: User-Agent: wasm-pack/0.8.1 (https://github.com/rustwasm/wasm-pack).

Fixes #651.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks @drager :)

@fitzgen
Copy link
Member

fitzgen commented Jun 3, 2019

It seems like CI has been failing for all the PRs recently and seems sort of related to binary-install. I saw some github emails in that repo, but haven't dug in yet. Do you happen to know what's up?

@drager
Copy link
Member Author

drager commented Jun 4, 2019

@fitzgen Hmm, I haven't really dug in the latest changes for binary-install just yet. Maybe @ashleygwilliams have an idea?

This is the test that fails though:

fn it_should_build_crates_in_a_workspace() {
let fixture = utils::fixture::Fixture::new();
fixture
.file(
"Cargo.toml",
r#"
[workspace]
members = ["blah"]
"#,
)
.file(
Path::new("blah").join("Cargo.toml"),
r#"
[package]
authors = ["The wasm-pack developers"]
description = "so awesome rust+wasm package"
license = "WTFPL"
name = "blah"
repository = "https://github.com/rustwasm/wasm-pack.git"
version = "0.1.0"
[lib]
crate-type = ["cdylib"]
[dependencies]
wasm-bindgen = "0.2"
"#,
)
.file(
Path::new("blah").join("src").join("lib.rs"),
r#"
extern crate wasm_bindgen;
use wasm_bindgen::prelude::*;
#[wasm_bindgen]
pub fn hello() -> u32 { 42 }
"#,
)
.install_local_wasm_bindgen();
fixture
.wasm_pack()
.current_dir(&fixture.path.join("blah"))
.arg("build")
.assert()
.success();
}

@ashleygwilliams
Copy link
Member

merging as this change is not related to the CI failure

@ashleygwilliams ashleygwilliams merged commit 95a4e30 into rustwasm:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm-pack's version checking calls violate crates.io's crawler policy
3 participants