Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tool): wasm-opt is a tool variant #687

Merged
merged 3 commits into from
Feb 7, 2020
Merged

refactor(tool): wasm-opt is a tool variant #687

merged 3 commits into from
Feb 7, 2020

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jul 19, 2019 •
edited
Loading

fixes #685 #781 #782

@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 19, 2019
@ashleygwilliams ashleygwilliams self-assigned this Jul 19, 2019
@ashleygwilliams ashleygwilliams force-pushed the refactor-opt branch 2 times, most recently from d2ce6a6 to 17e4d25 Compare July 19, 2019 15:39
@ashleygwilliams ashleygwilliams force-pushed the refactor-opt branch 2 times, most recently from 70d631a to 03d6e5f Compare January 15, 2020 21:48
@ashleygwilliams ashleygwilliams removed the work in progress do not merge! label Jan 15, 2020
@ashleygwilliams ashleygwilliams changed the title [WIP] refactor(tool): wasm-opt is a tool variant refactor(tool): wasm-opt is a tool variant Jan 15, 2020
EverlastingBugstopper
EverlastingBugstopper approved these changes Jan 15, 2020
View reviewed changes
src/command/test.rs Outdated Show resolved Hide resolved
src/generate.rs Show resolved Hide resolved
src/install/mod.rs Outdated Show resolved Hide resolved
src/install/mod.rs Show resolved Hide resolved
src/install/mod.rs Outdated Show resolved Hide resolved
src/install/tool.rs Show resolved Hide resolved
src/wasm_opt.rs Show resolved Hide resolved
@ashleygwilliams ashleygwilliams force-pushed the refactor-opt branch 3 times, most recently from d135a2e to 57968d8 Compare January 23, 2020 14:52
@ashleygwilliams ashleygwilliams modified the milestones: 0.9.0, 0.10.0, 0.9.1 Jan 31, 2020
This was linked to issues Feb 7, 2020
wasm-opt exits with signal 6 #782
Closed
wasm-opt exits with signal: 11 #781
Closed
@ashleygwilliams ashleygwilliams merged commit 203a5f2 into master Feb 7, 2020
@ashleygwilliams ashleygwilliams deleted the refactor-opt branch February 7, 2020 17:22
@ghost ghost mentioned this pull request Jun 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EverlastingBugstopper EverlastingBugstopper EverlastingBugstopper approved these changes

Assignees

@ashleygwilliams ashleygwilliams

Labels
changelog - maintenance
Projects
None yet
Milestone
0.9.1
Development

Successfully merging this pull request may close these issues.

wasm-opt exits with signal 6 wasm-opt exits with signal: 11 refactor wasm-opt support to use new refactor
2 participants
@ashleygwilliams @EverlastingBugstopper