fix(test): only use exactly v0.24.0 geckodriver on windows #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
changed the title
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
bump-geckodriver-down
branch
from
7da929b
to
7af794b
Compare
ashleygwilliams
force-pushed
the
bump-geckodriver-down
branch
9 times, most recently
from
00b25e0
to
5db509d
Compare
ashleygwilliams
changed the title
ashleygwilliams
force-pushed
the
bump-geckodriver-down
branch
from
5db509d
to
00d08e7
Compare
Pauan
approved these changes
Jan 28, 2020
drager
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #770
it is true that this PR may install v0.24.0 when it is already installed. i'd like to get this release out and then actually address that by doing #775. we already have logic that does a lot of this checking and i'd rather reuse it than write some new stuff.