Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): only use exactly v0.24.0 geckodriver on windows #774

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jan 25, 2020

fixes #770

it is true that this PR may install v0.24.0 when it is already installed. i'd like to get this release out and then actually address that by doing #775. we already have logic that does a lot of this checking and i'd rather reuse it than write some new stuff.

@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jan 25, 2020
@ashleygwilliams ashleygwilliams changed the title [WIP] fix(test): drop geckodriver to v0.23.0 due windows regression > v0.24.0 fix(test): drop geckodriver to v0.23.0 due windows regression > v0.24.0 Jan 25, 2020
@ashleygwilliams ashleygwilliams changed the title fix(test): drop geckodriver to v0.23.0 due windows regression > v0.24.0 fix(test): drop geckodriver to v0.23.0 due windows regression >=v0.24.0 Jan 25, 2020
@ashleygwilliams ashleygwilliams force-pushed the bump-geckodriver-down branch 9 times, most recently from 00b25e0 to 5db509d Compare January 27, 2020 20:19
@ashleygwilliams ashleygwilliams changed the title fix(test): drop geckodriver to v0.23.0 due windows regression >=v0.24.0 fix(test): only use exactly v0.24.0 geckodriver on windows Jan 27, 2020
Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my comment for clarification, this looks good.

src/test/webdriver/geckodriver.rs Show resolved Hide resolved
@ashleygwilliams ashleygwilliams merged commit f15a5ef into master Jan 28, 2020
@ashleygwilliams ashleygwilliams deleted the bump-geckodriver-down branch January 28, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

firefox tests are failing on windows
3 participants