Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added keywords (#707) #838

Merged
merged 1 commit into from
May 4, 2020
Merged

Added keywords (#707) #838

merged 1 commit into from
May 4, 2020

Conversation

lucashorward
Copy link
Contributor

@lucashorward lucashorward commented May 3, 2020

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

Closes #707

package.json files usually contain a keywords array so that npm can make searching easier. Currently the keywords from the Cargo.toml are not exported to the package.json, meaning they have to be done manually before a package is published to npm, or be difficult to find on npm.

This is my first edit, so please let me know if I have made some junior mistakes

@lucashorward
Copy link
Contributor Author

The test is failing for build_with_and_without_wasm_bindgen_debug - but when I run cargo test on master, this failure is also there..
Do I have a wrong configuration setting or something?

Copy link
Contributor

@Pauan Pauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Pauan Pauan merged commit de49201 into rustwasm:master May 4, 2020
@drager drager added this to the 0.10.0 milestone Jun 29, 2021
@lucashorward lucashorward deleted the keywords branch August 7, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom section in Cargo.toml, ex. [wasm]
3 participants