Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove appveyor and travis and use Github actions for tests #947

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

ashleygwilliams
Copy link
Member

🤕 do not merge 🤕

fixes #594

@palfrey
Copy link
Contributor

palfrey commented May 11, 2021

How's this going? Are you interested in patches to fix any of the current issues here?

@drager drager force-pushed the fix-ci branch 12 times, most recently from 8a1f5b6 to 9d66a8b Compare June 22, 2021 16:37
@azriel91
Copy link
Contributor

Heya @drager, I think the last CI failure can be fixed with the following changes (see example diff, which I've tacked on top of #851):

  • Updating wasm-bindgen-test expected version to 0.3.24 in tests/all/lockfile.rs

  • Removing the and(contains("[INFO]: Installing wasm-bindgen...")) line from tests/all/log_level.rs

    I suspect the Cache implementation means wasm-bindgen isn't installed multiple times across tests, so this line is not output.

@drager
Copy link
Member

drager commented Jun 29, 2021

Heya @drager, I think the last CI failure can be fixed with the following changes (see example diff, which I've tacked on top of #851):

* Updating `wasm-bindgen-test` expected version to `0.3.24` in `tests/all/lockfile.rs`

* Removing the `and(contains("[INFO]: Installing wasm-bindgen..."))` line from `tests/all/log_level.rs`
  I suspect the `Cache` implementation means `wasm-bindgen` isn't installed multiple times across tests, so this line is not output.

Thanks, I'm merging your PR now!

@drager drager force-pushed the fix-ci branch 2 times, most recently from 5291c34 to 7903c15 Compare June 29, 2021 15:55
@drager drager changed the title [WIP] fix ci fix: Remove appveyor and travis and use Github actions for tests Jun 29, 2021
@drager drager merged commit 340e348 into master Jun 29, 2021
@drager drager deleted the fix-ci branch June 29, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move tests and release to github actions
4 participants