-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Support WebIDL modules #31
Conversation
[ci skip]
Looks great to me! I'm mostly just assuming this matches the syntax of the spec itself but I don't see any issues in merging this |
[ci skip]
[ci skip]
[ci skip]
[ci skip]
@alexcrichton do you have any thoughts on the best way to represent scoped identifiers here? Right now I am just parsing the qualifying prefix to It also seems like we are going to want to intern the identifiers at some point for performance. |
I don't have too much of a preference myself, I don't really know a huge amount about WebIDL or modules or such, I just learned enough to get |
Just want to give a quick update on this. I've decided to spend some time working on a rewrite targeting nom 5 first since I've found it far less painful to work with than the current macro heavy implementation. I also wanted to take the opportunity to try and simplify the AST. I wasn't sure how a rewrite would be received so I've been working on that in a separate crate here. Once it's further along (can parse webidls) I'd be happy to donate the parser crate to this project (and take ownership of maintenance) if y'all think that's a good idea. |
Nice! We're not necessarily wed to any particular WebIDL parser or the way things are, so long as it serves the purposes of |
I do love the name |
whatwg/webidl#675 is dropped, so this should probably be closed. |
Ah ok! |
Companion PR to rustwasm/wasm-bindgen#1746; adds support for WebIDL modules.