Get referenced obj using dynamic GVK API Rebased #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nitish Malhotra <nitish.malhotra@gmail.com>
fix: rebase master
The spec allows for sink parameters to specify both a ref and a uri. In that case, the uri must be a path that is set on the resolved ref url. Only if no ref is specified must the uri be an absolute url. This makes the url type too strict for this field since url must always be absolute.
Some small clippy lint fixes as well
Use a shared fn build_service_url for both DynamicObject and Service types when getting the url via AddressableTypeExt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #1 opened by @nitishm
Duplicate of #7