Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to rebase #58 onto 3.5.0 for a new release #68

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Proposal to rebase #58 onto 3.5.0 for a new release #68

merged 2 commits into from
Sep 25, 2023

Conversation

maxwellmckinnon
Copy link

Work for issue #66 which is just a cherry picking of @spacecams work in #58 on top of 3.5.0.

maxwellmckinnon and others added 2 commits September 25, 2023 19:33
@maxwellmckinnon @ruuda
Import MaybeUninit changes from ruuda#58
d153729 
This is a squash of three commits by Maxwell McKinnon, who re-applied
the patches from ruuda#58 on top of the 3.5.0 release. Original messages
below:

 * read_4_bytes changed, all tests pass
 * change all of read.rs, tests pass
 * All changes from ruuda#58 from spacecams done and passing tests
@ruuda
Restore compatibility with Rust 1.40
2fbbe2c 
Rust 1.36 has no f32::from_le_bytes, but Rust 1.40 does. The
MaybeUninit::write is even newer, added in 1.55. That version is recent
enough that I'm not comfortable bumping the MSRV to such a recent
version, but 1.40 should be okay; Debian oldoldstable ships 1.41.1 at
this time.
@ruuda
Copy link
Owner

ruuda commented Sep 25, 2023

Thanks so much for picking this up! I see it’s impossible on GitHub to target a tag with a pull request, so I’ve advanced the release branch to point to 3.5.0, and I also added a rust-toolchain.toml there to make it easier to see what the supported Rust version is.

I thought these changes only required MaybeUninit, which was stabilized in 1.36, but it turns out MaybeUninit::write requires a much newer 1.55, and f32::from_le_bytes requires 1.40. I think 1.40 is still okay to bump the MSRV to, so I did that now. I squashed your commits into one and made sure Cargo.lock remains unchanged aside from the version update.

@ruuda ruuda merged commit 2fbbe2c into ruuda:release Sep 25, 2023
@maxwellmckinnon
Copy link
Author

Amazing, thanks Ruud!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxwellmckinnon @ruuda