Adding generation of custom 'class'-tags in div and img #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and <img> elements generated by ImagePicker
…sion, too. Added headers with version = 0.2.5
|
This is a good idea, due to some conflicts I can't merge this but I added this on 0.3.0 and gave you credit for the good idea! |
|
Is anyone else having issues with this not working? I am using version 0.3.0 via bower. data-img-src works fine, but data-img-class does nothing. |
|
Hi Kevin, maybe the bower version is wrong? Check the demo page http://rvera.github.io/image-picker and look at the options
It produces the expected result
|
|
Hi, kevinwheeler, tried use image-picker.js instead of image-picker.min.js and it is working. I guess image-picker.min.js not updated yet. |
|
uh, that's weird. Thanks @hariA will take a look at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to style the image picker with some classes within css.
There was no option to add custom classes to the div or img element generated by jQuery, so I added the tag 'data-img-class' to be used for that.
I hope this is of use for others, too. Would be glad if you accept this PR. Thanks!