chore: disable arm build for protoc_gen_js #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
reviewed
Mar 11, 2023
rvolosatovs
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rvolosatovs I have some time to work on this again over the next couple of weeks!
This PR disables ARM builds for protoc_gen_js due to extremely slow builds in the emulator. Both Bazel and protoc_gen_js need to be built, and Bazel cannot be built on ARM currently due to this bug.
Instead, I have created a bazel6 package for x86_64 in Alpine, so Bazel no longer needs to be built by us. I'll create an issue describing the lack of protoc_gen_js support on ARM, and continue working with Alpine to try and release bazel6 as an Alpine package with ARM support.