Windows - Serial Port Detection / Connection

[dcherman]

Detection:

In recent versions of SerialPort, there's support for listing available Serial Ports via SerialPort.list(function( err, results ) {})

I don't have access to a native linux / unix box to test support on there right now ( having problems with my VM ), but as for port detection, this works perfectly on Windows.

Connection:

Attempting to connect to a valid but non-arduino Serial Port results in app looking like it's hanging. Still looking at this to get more details on what's going on - if you connect explicitly to a valid arduino port, things seem to work fine ( the basic blink app works! )

[rwaldron]

Awesome!

[randallagordon]

I've been able to use the list method to get detection/connection working on my Windows and Ubuntu machines. I don't have an OSX machine around to ensure it is working properly there, however. Not sure if it's an acceptable change, but take a look and let me know if everything looks good:

https://github.com/randallagordon/johnny-five/tree/windows

[rwaldron]

@randallagordon can you make a PR :D

[randallagordon]

Will do!

[rwaldron]

YES! Exciting :)

I don't have any way of testing windows, so we're going to have to work together on ironing this out, I hope you have you're ready to be super patient ahah

[rwaldron]

@randallagordon I had to make an executive decision between landing this or #111 first. Based on how minimal your changes are, I decided that you might not mind if I did #111 first and then you could re-apply these changes? (sorry if that's a total pain in the ass)

[rwaldron]

Ok, I just tried merging this myself and I think we're better off letting you do it. Be warned, there is a lot of whitespace and large code movement changes, but I think your patch can still be easily written in. (sorry for messing this up)

[randallagordon]

No prob, that's the way I would have gone! However, it will be week or two before I can get around to it as I'm in the middle of moving at the moment.

I believe that #111 will allow for us Windows folks to specify a COM port and be good to go, too. Not quite as nice as auto detection, but I think it should work. Now that it has been merged, I'll give it a shot as soon as I get back to an Arduino.

[rwaldron]

No prob, that's the way I would have gone! However, it will be week or two before I can get around to it as I'm in the middle of moving at the moment.

I'm patient :)

I believe that #111 will allow for us Windows folks to specify a COM port and be good to go, too. Not quite as nice as auto detection, but I think it should work. Now that it has been merged, I'll give it a shot as soon as I get back to an Arduino.

Indeed—this is actually why I decided to land that one first, but you're right: windows needs the auto-detection! I'll keep my mits out of Board until you wrap this up :)

Thanks again for this!