Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to set a serial port in board options #111

Closed
wants to merge 1 commit into from
Closed

Allow the user to set a serial port in board options #111

wants to merge 1 commit into from

Conversation

theycallmeswift
Copy link
Contributor

I've run into a few issues where the serial port is not properly detected by Johnny-five and right now there is no easy way to set the correct port through the options hash. I've been doing something similar over in BreakfastSerial.

Ex.

var board = new Board({ port: "/dev/tty.usbfoo1234" });

Thoughts?

Ex. new Board({ port: "/dev/tty.usbfoo1234" })
@rwaldron
Copy link
Owner

rwaldron commented Apr 4, 2013

Exciting!

As soon as firmata/firmata.js#17 is resolved, I will land this :D

@theycallmeswift
Copy link
Contributor Author

Cool. The whole constructor could use a refactor. It's a little hard to follow right now. I'll work on that once these two go in.

@rwaldron
Copy link
Owner

rwaldron commented Apr 4, 2013

Thanks, that sounds good.

In the meantime, would you mind fixing up the style (whitespace, etc) to match the rest? Thanks!

(usually I just do that myself, but I figured I'd ask anyway :D )

@theycallmeswift
Copy link
Contributor Author

I think I did a pretty good job of matching your style. If you see any glaring issues, let me know - I'm happy to fix them.

@theycallmeswift
Copy link
Contributor Author

Only exception being the self stuff, which I find easier to deal with when you're dealing with nested binding callbacks.

@theycallmeswift
Copy link
Contributor Author

Yay! Glad this went in. Thanks!

@rwaldron
Copy link
Owner

Thanks me? No! Thank you! ...for writing the patch to add the support :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants