Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX #5 #6

Merged
merged 2 commits into from
Mar 6, 2016
Merged

FIX #5 #6

merged 2 commits into from
Mar 6, 2016

Conversation

goooseman
Copy link
Contributor

No description provided.

Alexander Gusev added 2 commits March 6, 2016 21:57
@goooseman goooseman changed the title FIX #2 FIX #5 Mar 6, 2016
@rwatts3 rwatts3 self-assigned this Mar 6, 2016
@rwatts3
Copy link
Owner

rwatts3 commented Mar 6, 2016

So in essence using the export forced you to import Cloudinary namespace ?

@goooseman
Copy link
Contributor Author

We can't use export in Metoer 1.2. Maybe because of the NodeJS version.

@rwatts3
Copy link
Owner

rwatts3 commented Mar 6, 2016

Got it,

Ecmascript is available for 1.2, but Modules is bound to 1.3 makes sense.

![](https://link.nylas.com/open/7hecocdyi1g0zt42ceol45sjc/dbf503b48f17494aa518
025dd5a3b408)

On Mar 6 2016, at 1:04 pm, Alexander Gusev <notifications@github.com>
wrote:

We can't use export in Metoer 1.2. Maybe because of the NodeJS version.

—
Reply to this email directly or [view it on GitHub](https://github.com/rwatts3
/orionjs-cloudinary/pull/6#issuecomment-192975170).![](https://github.com/noti
fications/beacon/AFFsSSRFef3eKfw1GSU4rPL9OAFfnqdOks5pqzM0gaJpZM4HqV2T.gif)

@rwatts3
Copy link
Owner

rwatts3 commented Mar 6, 2016

Merging now, future reference let's put it in a patch branch so it doesn't conflict with the master updates.

rwatts3 added a commit that referenced this pull request Mar 6, 2016
@rwatts3
Merge pull request #6 from goooseman/master
020eab5 
FIX #5
@rwatts3 rwatts3 merged commit 020eab5 into rwatts3:master Mar 6, 2016
@rwatts3 rwatts3 mentioned this pull request Mar 6, 2016
Closed
rwatts3 added a commit that referenced this pull request Mar 6, 2016
@rwatts3
Merge #6
fb0eb6a 
For some reason the merge didn't take.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwatts3 rwatts3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goooseman @rwatts3