Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #161 gates do not open #727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Lihis
Copy link
Contributor

@Lihis Lihis commented Oct 26, 2019

Fixes the gates opening/closing.

Distance to stop the gate when it's closing and would collide with a ped or a car has been tuned with eye precision so not 1:1 with original game.

@codecov
Copy link

codecov bot commented Oct 26, 2019

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 11.12%. Comparing base (51b7264) to head (b409a8c).
Report is 34 commits behind head on main.

Files with missing lines Patch % Lines
rwengine/src/script/modules/GTA3ModuleImpl.inl 0.00% 38 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #727      +/-   ##
==========================================
- Coverage   18.12%   11.12%   -7.00%     
==========================================
  Files         252      252              
  Lines       22938    22976      +38     
  Branches     5769     5794      +25     
==========================================
- Hits         4158     2557    -1601     
- Misses      17659    18890    +1231     
- Partials     1121     1529     +408     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant