Allow HTTP extension methods #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fun! There's actually a test for this, but it doesn't go through the full server. Can you add a testbench test (testbench/src/servers) that dispatches an http request with an extension method and ensures it works? |
|
Okay, added a test for that. It also includes a check that verbs outside of extensions still return errors. |
SergioBenitez
force-pushed
the
master
branch
2 times, most recently
from
88d5068 to
6f40f1e
Compare
Also implements 'From<Infallible>' for 'ParseMethodError'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While you can create routes with HTTP methods such as PROPFIND and REPORT, Rocket will return 400 errors when handling these requests as it errors for any unknown method. This was fixed by just parsing unknown Hyper methods into Rocket methods.