Improve http::Status by implementing traits via derive macro.
#2850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergioBenitez
force-pushed
the
frondeus/http_status_derive
branch
from
8ccefbb to
f5c841c
Compare
`PartialEq` when not derived results in `StructuralPartialEq` not being implemented. As this was the case for `http::Status`, matching against constants like `Status::Unauthorized` was not allowed. This commit replaces the manual implementations of equality traits (`PartialEq`, `Eq`) and ordering traits (`PartialOrd`, `Ord`) for `http::Status` with `#[derive]`. Resolves rwf2#2844.
SergioBenitez
force-pushed
the
frondeus/http_status_derive
branch
from
f5c841c to
5d73d91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Reasoning
PartialEqwhen not implemented via derive macro, lacksStructuralPartialEq.It causes undesired side effect, that the compiler rejects
constants like
Status::Unauthorizedto be used in pattern(for example in the
matchexpression)Solution
Because the current manual implementation is trivial and matches
derived code 1:1, we can replace it with
#[derive]withoutchanges in the behaviour
Fixes #2844